Hi, the following two patches fixes issues found by Coverity.
bye, Sumit
From e684620d8f6ead4e6c82910bfe37f06cbd810a7f Mon Sep 17 00:00:00 2001 From: Sumit Bose <sb...@redhat.com> Date: Mon, 9 Jul 2012 20:45:12 +0200 Subject: [PATCH 1/2] Remove resource leak in sssdpac_import_authdata Fixes https://fedorahosted.org/sssd/ticket/1409 --- src/sss_client/sssd_pac.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/sss_client/sssd_pac.c b/src/sss_client/sssd_pac.c index cbcfe1d..0cce43d 100644 --- a/src/sss_client/sssd_pac.c +++ b/src/sss_client/sssd_pac.c @@ -83,8 +83,6 @@ sssdpac_import_authdata(krb5_context kcontext, { struct sss_cli_req_data sss_data; int ret; - uint8_t *repbuf; - size_t replen; int errnop; char *data = NULL; struct sssd_context *sssdctx = (struct sssd_context *)request_context; @@ -97,7 +95,7 @@ sssdpac_import_authdata(krb5_context kcontext, sss_data.data = authdata[0]->contents; ret = sss_pac_make_request(SSS_PAC_ADD_PAC_USER, &sss_data, - &repbuf, &replen, &errnop); + NULL, NULL, &errnop); if (ret != 0) { /* Ignore the error */ } -- 1.7.7.6
From ecf23a559d5405d772f9d67f8d332836b6d90b33 Mon Sep 17 00:00:00 2001 From: Sumit Bose <sb...@redhat.com> Date: Tue, 10 Jul 2012 09:42:51 +0200 Subject: [PATCH 2/2] Remove dead code in ipa_subdomains_handler_done() Fixes https://fedorahosted.org/sssd/ticket/1410 --- src/providers/ipa/ipa_subdomains.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c index 55ecea0..6d27b13 100644 --- a/src/providers/ipa/ipa_subdomains.c +++ b/src/providers/ipa/ipa_subdomains.c @@ -459,7 +459,7 @@ static void ipa_subdomains_handler_done(struct tevent_req *req) done: talloc_free(ctx); - ipa_subdomains_reply(be_req, (ret == EOK ? DP_ERR_OK : DP_ERR_FATAL), ret); + ipa_subdomains_reply(be_req, DP_ERR_FATAL, ret); } -- 1.7.7.6
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
