On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: > On 08/08/2012 04:24 PM, Jakub Hrozek wrote: > >On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > >>This bug was probably introduced with the subdomain patches. The > >>problem was that sss_dp_get_domains_send() is called even for the local > >>provider. There are certainly many possible solutions of this issue. I > >>decided to modify sss_dp_issue_request() to call the callback > >>immediately if it is issued for local domain. This way, I believe, we > >>can avoid further problems with issuing request for local domains. > > > >I don't think this is the best solution. > > > >First, it leaves the check_provider of the per-domain structures we use > >in responders around while duplicating the same functionality in the DP. > >At the very least, the patch should remove the "check_provider" tests from > >the existing loops. > > > >What I think would be even better solution is to > > 1) in the RC just fix the subdomains code so that it shortcuts or > > doesn't run at all for LOCAL lookups. > > Patch is attached.
Thank you, this works for me. I'm seeing this warning when LOCAL users are enumerated (as opposed to a direct lookup): (Mon Aug 13 11:06:58 2012) [sssd[nss]] [setent_notify] (0x0010): BUG: a callback did not free its request. May leak memory Given that the LOCAL domain is mostly useful for testing right now, I've just filed a ticket: https://fedorahosted.org/sssd/ticket/1477 Ack _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel