On Thu, Sep 20, 2012 at 07:12:40PM +0200, Jakub Hrozek wrote: > The code works as advertized. > > I only have some minor nitpicks style-wise: > > +static int nss_clear_memcache(DBusMessage *message, > + struct sbus_connection *conn) > > Please align the line after the linebreak. > > + struct nss_ctx *nctx = (struct nss_ctx*)rctx->pvt_ctx; > (and elsewhere) Please put whitespace after the cast. > > sss_mmap_cache_reinit: > We have a convention to call our "local" talloc contexts tmp_ctx. We usually > also allocate them on NULL so that a run with valgrind would immediatelly > reveal them as leaks[*]
Sorry I forgot to add the point I intended to add: [*] I'm actually thinking that for async tevent requests it might be safe to use "state" as the temp context. Unless they are long-running and especially recursive such as group processing to avoid growing the context. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
