On Wed, 2012-10-31 at 14:36 -0400, Stephen Gallagher wrote:
> On Wed 31 Oct 2012 02:16:02 PM EDT, Simo Sorce wrote:
> > On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote:
> >> fail:
> >> - DEBUG(2, ("Failed to save group [%s]\n",
> >> - name ? name : "Unknown"));
> >> + DEBUG(SSSDBG_MINOR_FAILURE,
> >> + ("Failed to save group [%s]: [%s]\n",
> >> + name ? name : "Unknown",
> >> + strerror(ret)));
> >
> > Given you already print the strerror() in all previous debug messages,
> > does it make sense to repeat it here ?
> >
> > (Otherwise ACK, patch looks good)
> >
>
> Well, this is a catch-all for things like ENOMEM, which my debug
> messages don't catch. (And as it happens, it turned out that the bug
> this was intended to catch was actually reporting ENOMEM and wasn't
> caught by my other messages)[1]
>
> So I'm leaving it in. Too much information is always better than too
> little in debug logs.
>
> [1] See Jakub's patch about the off-by-one error. Basically, we were
> trying to allocate an array of zero length, getting NULL back and
> treating it as an out-of-memory error.
Ok, then ACK.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
