While I was working on an unrelated patchset I couldn't help fixing some of the code to properly use tevent_req style and naming conventions.
This will bring this code in line with our tevent_req coding style and hopefully make it more readable to eyes used to the tevent_req style. It also fixes use of some inconsistent function names. The krb5_auth.c changes are a bit tricky because I needed to change the flow in several places and built helper functions to reduce a bit some of the long functions. I have been careful to make sure I did not change the actual program flow and the patches work fine for me, so I am now dropping the RFC and asking for review and inclusion in master. Simo Sorce (5): Fix tevent_req style for krb5_auth Fix ipa_subdomain_id names and tevent_req style Fix tevent_req style for get_netgroup in ipa_id Streamline ipa_account_info handler Use an entry type mask macro to filter entry types src/providers/data_provider.h | 1 + src/providers/ipa/ipa_id.c | 252 ++++++++-------- src/providers/ipa/ipa_id.h | 10 +- src/providers/ipa/ipa_subdomains_id.c | 75 ++--- src/providers/krb5/krb5_access.c | 6 +- src/providers/krb5/krb5_auth.c | 556 +++++++++++++++------------------ src/providers/krb5/krb5_auth.h | 2 +- src/providers/krb5/krb5_wait_queue.c | 12 +- src/providers/ldap/ldap_id.c | 2 +- src/providers/proxy/proxy_id.c | 2 +- 10 files changed, 432 insertions(+), 486 deletions(-) _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
