On 11/03/2012 12:01 AM, Simo Sorce wrote:
On Fri, 2012-11-02 at 22:58 +0100, Pavel Březina wrote:
+#define SSSDBG_IMPORTANT_INFO 0x0010 /* level 0 */
#define SSSDBG_FATAL_FAILURE 0x0010 /* level 0 */
#define SSSDBG_CRIT_FAILURE 0x0020 /* level 1 */
#define SSSDBG_OP_FAILURE 0x0040 /* level 2 */
Uhm I am not particularly happy with proliferating macros, but I see why
you would like a better name, however if it isn't a fatal failure
shouldn;t we use a higher debug level ?
Also do not define numbers just define an alias to a macro so we do not
risk changing one and not the other.
Well, in this particular case I didn't consider it as an alias to
SSSDBG_FATAL_FAILURE, but as a separate level, which by coincidence
happened to be an existing number (because I didn't want to change its
value). In general, I would prefer a different number for this category.
But I think we should not mess with existing debug levels until a
complete refactoring of their usage is done (I think there is a ticket
for that).
I propose:
#define SSSDBG_IMPORTANT_INFO SSSDBG_OP_FAILURE
Simo.
Thank you for the review, I'll send new patches tomorrow.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
