On Thu, Feb 07, 2013 at 04:43:11PM +0100, Ondrej Kos wrote:
> Hi,
> attached find five for 1.5 patches backporting fix of security issue
> CVE-2013-0219, the definition of new debug macros (just the values
> for the backport purposes, no interface change), and atomic I/O.
> --
> Ondrej Kos
> Associate Software Engineer
> Identity Management
> Red Hat Czech
>
> phone: +420-532-294-558
> cell: +420-736-417-909
> ext: 82-62558
> loc: 1013 Brno 1 office
> irc: okos @ #brno
Patch 0001: Ack
Patch 0002: Ack
Patch 0003: Ack
Patch 0004: Ack with a nitpick:
> From 28ddaef8a4c16090e9b995952de476212f40ede0 Mon Sep 17 00:00:00 2001
> From: Ondrej Kos <o...@redhat.com>
> Date: Thu, 7 Feb 2013 11:26:45 +0100
> Subject: [PATCH 4/5] TOOLS: Use file descriptor to avoid races when creating
> a home directory
> +static int
> +copy_file(int ifd,
> + int dest_dir_fd,
> + const char *file_name,
> + const char *full_path,
> + const struct stat *statp,
> + uid_t uid, gid_t gid)
> +{
> int ofd = -1;
> + errno_t ret;
> char buf[1024];
> ssize_t cnt, written, res;
I will remove the "res" variable before pushing. It is unused now.
> - struct stat fstatbuf;
> + struct timespec timebuf[2];
Patch 0005: Ack.
I will also apply upstream cc542ca566355d8dd71bca62e3c564243120455e on
top of all these to avoid introducing the Coverity warning (even though
we don't scan 1.5 with Coverity anymore IIRC).
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
