On Mon, Feb 18, 2013 at 07:13:00PM +0100, Milan Cejnar wrote: > On 02/18/2013 05:20 PM, Jakub Hrozek wrote: > >On Mon, Feb 18, 2013 at 12:44:10PM +0100, Jakub Hrozek wrote: > >> * We also usually put the short description as the first line, an empty > >> line, the full URL of the ticket fixed, an empty line and then a > >> short description of the problem fixed. It's somewhat similar to > >> kernel's process (see > >> http://www.kernel.org/doc/Documentation/SubmittingPatches bullet point > >> 15) for example) I realize this info is missing from > >> https://fedorahosted.org/sssd/wiki/DevelTutorials and I'll add it > >> there. > >I added a loose guideline and an example to: > >https://fedorahosted.org/sssd/wiki/DevelTutorials#Patchmetadata > >_______________________________________________ > >sssd-devel mailing list > >sssd-devel@lists.fedorahosted.org > >https://lists.fedorahosted.org/mailman/listinfo/sssd-devel > Hello, > I'm sending the second patch to the ticket > https://fedorahosted.org/sssd/ticket/1756 > > - sorry for starting the second thread earlier this day > - commit message changed (hopefully) according to your recommendations > - the second patch is squashed onto the first one, hope it's alright > this way >
The code looks good and works as advertised. I tested a case where the error message was missing the newline previously (sss_cache) and one that had it (sss_debuglevel). Both error messages look good to me. Ack _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel