On 07/30/2013 08:19 AM, Lukas Slebodnik wrote:
ehlo,
Attached patches fix ticket #1759
sss_cache -N/-n should invalidate the hash table in sssd_nss
LS
Nack.
The hash table is cleared successfully, however the netgroup is not
removed from the sysdb when it is not found in ldap. Therefore the
following set of commands still returns the netgroup, although it should
not:
$ getent netgroup ng-1
ng-1 ( ,,bobby,example.com) ( ,,johny.example.com)
...delete ng-1 from ldap
$ sudo sss_cache -N
$ getent netgroup ng-1
ng-1 ( ,,bobby,example.com) ( ,,johny.example.com)
struct sbus_method monitor_nss_methods[] = {
{ MON_CLI_METHOD_PING, monitor_common_pong },
{ MON_CLI_METHOD_RES_INIT, monitor_common_res_init },
{ MON_CLI_METHOD_ROTATE, responder_logrotate },
{ MON_CLI_METHOD_CLEAR_MEMCACHE, nss_clear_memcache},
+ { MON_CLI_METHOD_CLEAR_ENUM_CACHE, nss_clear_netgroup_hash_table},
{ NULL, NULL }
};
Please, rename the ENUM_CACHE to what the command actually does (clears
the netgroup table).
Also put somewhere a debug message that netgroup in-memory cache is
beeing cleared, like it is done with the memcache:
[nss_clear_memcache] (0x0400): Clearing memory caches.
+errno_t nss_orphan_netgroups(struct nss_ctx *nctx) {
Break the line before the brace.
+ if (!nctx || !nctx->netgroups) {
+ return EINVAL;
+ }
You can return EOK if nctx->netgroups == NULL, since the table doesn't
exist, it is successfully cleared.
Since hash_delete() does not free the pointer itself, is the netgroup
entry still deleted via setnetgrent_result_timeout()? If so, please
comment it in the code.
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
