On 09/13/2013 04:52 PM, Lukas Slebodnik wrote:
ehlo,

Attached patch resolves ticket #2075

LS

Hi,
minor nack.

+    ret = sdap_get_netgroup_primary_name(memctx, opts, attrs, dom, &name);
+    if (ret != EOK) {
+        DEBUG(SSSDBG_OP_FAILURE, ("Failed to get netgroup name\n"));
+            goto fail;
+        }

Wrong indentation ^^ otherwise LGTM

Can you provide steps to reproduce please? I tries following netgroups:

dn: cn=ng-1,ou=Netgroups,dc=ldap,dc=pb
objectClass: top
objectClass: nisNetgroup
cn: ng-1
cn: ng-3
nisNetgroupTriple: (,,bobby,example.com)
nisNetgroupTriple: (,,johny.example.com)

dn: cn=ng-3,ou=Netgroups,dc=ldap,dc=pb
objectClass: top
objectClass: nisNetgroup
cn: ng-3
nisNetgroupTriple: (,,ajohny.example.com)
nisNetgroupTriple: (,,abobby,example.com)

$ getent netgroup ng-1
ng-1                  ( ,,bobby,example.com) ( ,,johny.example.com)
$ getent netgroup ng-3
ng-3                  ( ,,bobby,example.com) ( ,,johny.example.com)

But I got the same result (ng-1, no errors) with and without the patch.

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to