On Mon, Sep 16, 2013 at 10:35:07AM +0200, Lukas Slebodnik wrote: > On (22/07/13 11:43), Jakub Hrozek wrote: > >On Fri, Jul 19, 2013 at 03:36:22PM +0200, Lukas Slebodnik wrote: > >> On (19/07/13 10:29), Jakub Hrozek wrote: > >> >On Thu, Jul 18, 2013 at 01:09:11PM +0200, Lukas Slebodnik wrote: > >> >> ehlo, > >> >> > >> >> I tested some patches with old distro and I spotted warnings. > >> >> -- uninitialized variable (gcc 4.4.7) > >> >> -- macro AM_PROG_AR not found in library (automake 1.11.1) > >> >> > >> >> I checked them and all warnings should be harmless, but anyway we don't > >> >> like > >> >> warnings. > >> >> > >> >> Two patches are attached. > >> >> > >> >> LS > >> > > >> >Patch #1 really needs to be split into two, the Makefile.am/sssd.spec.in > >> >is a separate issue. > >> I removed changes to files Makefile.am/sssd.spec.in. > >> (I use those changes only internally.) > >> > >> > > >> >Patch #2 looks OK to me, is the automake version you tested with (1.11.1) > >> >the one shipped on RHEL5? > >> RHEL6, master can not be built on RHEL5. > >> > >> Updated patches are attached > >> > >> LS > > > >[PATCH 1/2] Fix warnings: uninitialized variable > >Ack after all. I checked all the functions you touched and I think GCC > >is simply wrong. However, setting the variables is OK and doesn't change > >the flow in any way. > > > >[PATCH 2/2] Fix autotols warnings: macro xyz not found in library > >Ack, builds fine on Fedora and RHEL6. > > I tested Michal's patch "[PATCH] Check slot validity before MC_SLOT_TO_PTR" > on 1-9 branch and there are a lot of automake warnings on fedora 19. > > /usr/share/automake-1.13/am/ltlibrary.am: > archiver requires 'AM_PROG_AR' in 'configure.ac' > > The 2nd patch is attached for sssd-1-9 branch. > > LS
Build passed on RHEL5 which this patch seems to be targeting and the remaining autoconf warnings were unrelated: $ [(sssd-1-9)] autoreconf -if Copying file build/mkinstalldirs Putting files in AC_CONFIG_AUX_DIR, `build'. src/man/Makefile.am:38: wildcard $(srcdir: non-POSIX variable name src/man/Makefile.am:38: (probably a GNU make extension) src/man/Makefile.am:103: wildcard $(srcdir: non-POSIX variable name src/man/Makefile.am:103: (probably a GNU make extension) src/man/Makefile.am:106: addprefix $(srcdir: non-POSIX variable name src/man/Makefile.am:106: (probably a GNU make extension) src/man/Makefile.am:106: shell grep '\[type:docbook\]' $(PO4A_CONFIG: non-POSIX variable name src/man/Makefile.am:106: (probably a GNU make extension) src/man/Makefile.am:107: filter-out $(CFG_PAGES: non-POSIX variable name src/man/Makefile.am:107: (probably a GNU make extension) ACK. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel