On (22/10/13 14:59), Jakub Hrozek wrote: >On Fri, Oct 11, 2013 at 09:59:17AM +0200, Jakub Hrozek wrote: >> On Fri, Oct 11, 2013 at 09:37:54AM +0200, Sumit Bose wrote: >> > On Thu, Oct 10, 2013 at 02:49:13PM -0400, Stephen Gallagher wrote: >> > > -----BEGIN PGP SIGNED MESSAGE----- >> > > Hash: SHA1 >> > > >> > > On 10/10/2013 02:13 PM, Jakub Hrozek wrote: >> > > > Hi, >> > > > >> > > > if an entry is removed from LDAP and searched by SID, the SID >> > > > lookup code doesn't handle ENOENT and doesn't remove the stray >> > > > entry from cache. The attached patch fixes that. >> > > > >> > > >> > > One minor nitpick (no need to resend for review): the >> > > SSSBG_FATAL_FAILURE line is > 79 characters. Please reflow it. >> > > >> > > Otherwise, code looks good to me. Ack. >> > >> > I agree, I just wonder if the new code can be move to a new call like >> > e.g. sysdb_delete_by_sid() to make it easier to reuse it? >> > >> > bye, >> > Sumit >> >> Yes, I also noticed there is a duplication of search-by-sid functions in >> master. I will send updated patches, probably next week when I'm back. I >> don't think it's a pressing issue. > >New patches attached. I haven't done anything about the duplication, I >think it should better be solved when following up on Ondra's patches as >the duplication (sysdb_search_object_by_sid vs >sysdb_search_entry_by_sid) was introduced there.
Works fine. ACK LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel