On Thu, Dec 05, 2013 at 02:59:40PM +0100, Sumit Bose wrote: > > > > > > diff --git a/src/providers/ad/ad_subdomains.c > > > > > > b/src/providers/ad/ad_subdomains.c > > > > > > index > > > > > > 73190faa1e7e995123f12e2200ab00fb40f3b256..282875ad38f3d0d3f4b6a3026fa2461f9af6da1f > > > > > > 100644 > > > > > > --- a/src/providers/ad/ad_subdomains.c > > > > > > +++ b/src/providers/ad/ad_subdomains.c > > > > > > @@ -652,5 +652,11 @@ int ad_subdom_init(struct be_ctx *be_ctx, > > > > > > return EFAULT; > > > > > > } > > > > > > > > > > > > + ret = sysdb_update_subdomains(be_ctx->domain); > > > > > > + if (ret != EOK) { > > > > > > + DEBUG(SSSDBG_OP_FAILURE, ("sysdb_update_subdomains > > > > > > failed.\n")); > > > > > > + return ret; > > > > > > > > > > Since this is only needed if sssd starts offline I wonder if we should > > > > > fail here or, or if it would be better to just print a more detailed > > > > > log > > > > > message at a more important log level explaining what might happen > > > > > and continue? > > > > > > > > > > > + } > > > > > > + > > > > > > return EOK; > > > > > > } > > > > > > diff --git a/src/providers/ipa/ipa_subdomains.c > > > > > > b/src/providers/ipa/ipa_subdomains.c > > > > > > index > > > > > > 4f7627eddb9c54d68e45be876157057f3c30b422..cc0b5394bb8620abb6da148753c46d38a2eab3fe > > > > > > 100644 > > > > > > --- a/src/providers/ipa/ipa_subdomains.c > > > > > > +++ b/src/providers/ipa/ipa_subdomains.c > > > > > > @@ -1291,6 +1291,12 @@ int ipa_subdom_init(struct be_ctx *be_ctx, > > > > > > DEBUG(SSSDBG_MINOR_FAILURE, ("Failed to add subdom offline > > > > > > callback")); > > > > > > } > > > > > > > > > > > > + ret = sysdb_update_subdomains(be_ctx->domain); > > > > > > + if (ret != EOK) { > > > > > > + DEBUG(SSSDBG_OP_FAILURE, ("sysdb_update_subdomains > > > > > > failed.\n")); > > > > > > + return ret; > > > > > > > > > > same here > > > > > > > > > > bye, > > > > > Sumit > > > > > > > > Good idea, see attached patch. I also removed one FIXME since we do what > > > > the FIXME describes now. > > > > > > Sorry, I sent the previous patch by accident. > > > > And now with the right one...sigh..sorry. > > ACK
Pushed to master and sssd-1-11 _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel