On (02/09/14 14:23), Nikolai Kondrashov wrote:
>On 09/02/2014 02:13 PM, Lukas Slebodnik wrote:
>>On (02/09/14 13:27), Nikolai Kondrashov wrote:
>>>On 09/02/2014 01:02 PM, Lukas Slebodnik wrote:
>>>>We use talloc and valgrind needn't find memory leaks.
>>>>For this purpose, we have functions in file src/tests/leak_check.c
>>>
>>BTW
>>For tesing purposes, I reverted commit
>>d528e4960bf233bc002f9676919ede196c91564c
>
>Ah, this one is a good source of a failure.
>
>>>Thanks Lukas, this seems to work fine with the exception of this one error
>>>in refcount-tests:
>>>
>>>==2842== Syscall param timer_create(evp) points to uninitialised byte(s)
>>>==2842== at 0x977FE72: timer_create@@GLIBC_2.3.3 (timer_create.c:82)
>>>==2842== by 0x4E3647B: srunner_run (in /usr/lib64/libcheck.so.0.0.0)
>>>==2842== by 0x401616: main (refcount-tests.c:233)
>>>==2842== Address 0xffefff460 is on thread 1's stack
>>>
Patch for this issue is on the list:
"[PATCH] refcount-tests: Do not force to run test in CK_FORK mode"
I updated also readme file and new version is attached.
This patch is blocked by ""[PATCH] refcount-tests: ..."
LS
>From 4b20f833f71c9014b0874b5a899d71f0bdbf9ca3 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik <lsleb...@redhat.com>
Date: Tue, 2 Sep 2014 12:00:03 +0200
Subject: [PATCH] CI: Do not try to find memory leaks with valgrind
We use talloc and valgrind needn't find memory leaks.
For this purpose, we have functions in file src/tests/leak_check.c
---
contrib/ci/README.md | 3 +--
contrib/ci/run | 7 ++-----
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/contrib/ci/README.md b/contrib/ci/README.md
index
6c87200db3db8d49f8b9470a125e44a62d12d046..6b5f7f30eac8327d5aa45c3bfefd57e8d3109fe0
100644
--- a/contrib/ci/README.md
+++ b/contrib/ci/README.md
@@ -12,8 +12,7 @@ It accepts options to choose from three test sets:
"essential", "moderate" and
"rigorous" (-e/-m/-r), with the essential set selected by default.
Essential tests include building everything and running the built-in test
-suite under Valgrind, completing in under 5 minutes. Valgrind failures are
-ignored for now.
+suite under Valgrind, completing in under 5 minutes.
Moderate tests include essential tests, plus a distcheck target build and mock
package builds for Fedora and RHEL on Red Hat distros. They complete in about
diff --git a/contrib/ci/run b/contrib/ci/run
index
b8a296aea5b58e88382677eb1b4cff1edf420b8f..901a162b6698daf8b3d340362512f654504bfbfc
100755
--- a/contrib/ci/run
+++ b/contrib/ci/run
@@ -194,8 +194,6 @@ function build_debug()
# Not building "tests" due to https://fedorahosted.org/sssd/ticket/2350
stage make-tests make-check-wrap -j $CPU_NUM check -- true
- # Ignored until issues found by Valgrind are fixed
- status=0
CK_FORK=no \
stage make-check-valgrind \
make-check-wrap -j $CPU_NUM check -- \
@@ -203,9 +201,8 @@ function build_debug()
valgrind-condense 99 '!(*.py)' -- \
--vgdb=no \
--trace-children=yes \
- --trace-children-skip='*/bin/*,*/sbin/*' \
- --leak-check=full ||
- status=$?
+ --trace-children-skip='*/bin/*,*/sbin/*'
+
mv "$test_dir" ci-test-dir
if "$MODERATE"; then
--
2.1.0
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
