-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 When there was more than one SSSD domain configured, actions performed against domains later in the list would be incorrectly told to use the first domain as the base for locating subdomains. This was because we were rewinding the ->prev list on the sss_domain_info object, which is only intended to be used by confdb code. The correct approach was to use only the parent linkage, which would take us up to the top-level domain in this SSSD domain. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1
iEYEARECAAYFAlQi3YEACgkQeiVVYja6o6PqAACgjb4ISPCELnMMBIoKKHX/tj8r UdgAmQHRTCMC0BQo8oBlFy4ZKNj1gshs =AaTR -----END PGP SIGNATURE-----
>From fee75b35053029a9b856a231f99fa607bd91e8e4 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <sgall...@redhat.com> Date: Wed, 24 Sep 2014 11:00:44 -0400 Subject: [PATCH] UTIL: Do not change SSSD domains in get_domains_head When there was more than one SSSD domain configured, actions performed against domains later in the list would be incorrectly told to use the first domain as the base for locating subdomains. This was because we were rewinding the ->prev list on the sss_domain_info object, which is only intended to be used by confdb code. The correct approach was to use only the parent linkage, which would take us up to the top-level domain in this SSSD domain. --- src/util/domain_info_utils.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c index 2d29743c9b1a934ffb5d65d0943111b5184a2cec..8933f52353abd63ce825e80b1cde2aad03ed7797 100644 --- a/src/util/domain_info_utils.c +++ b/src/util/domain_info_utils.c @@ -34,9 +34,6 @@ struct sss_domain_info *get_domains_head(struct sss_domain_info *domain) /* get to the top level domain */ for (dom = domain; dom->parent != NULL; dom = dom->parent); - /* proceed to the list head */ - for (; dom->prev != NULL; dom = dom->prev); - return dom; } -- 2.1.0
0001-UTIL-Do-not-change-SSSD-domains-in-get_domains_head.patch.sig
Description: PGP signature
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel