On (14/01/15 21:46), Pavel Březina wrote: >On 01/14/2015 02:24 PM, Lukas Slebodnik wrote: >>On (12/01/15 13:17), Pavel Březina wrote: >>>On 01/10/2015 06:08 PM, Lukas Slebodnik wrote: >>>>ehlo, >>>> >>>>The attached patch fixes clang warning -Wempty-body. >>>>The other alternative is to put put the semicolon on a separate line to >>>>silence >>>>this warning as it was suggested by compiler. >>>> >>>>LS >>> >>>If we are going to fix this warning, I would prefer this way: >>> >>>for (...) { >>> /* no op */ >>It is inside of macro but I don't mind. >> >>attached is fixed version. >> >>LS > >Ack. > >But out of curiosity, there are lots of for cycles with empty body. Where? Thry t find one :-)
>Why those do not trigger this warning? It is possible that semicolon was not on the same line as keyword "for" You can easily overlook semicolon after closing brace. LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel