On Mon, May 25, 2015 at 03:28:30PM +0200, Lukas Slebodnik wrote: > On (22/05/15 16:13), Jakub Hrozek wrote: > >On Thu, May 21, 2015 at 01:43:19PM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> There were some failed tests in ci log > >> http://sssd-ci.duckdns.org/logs/job/12/67/fedora_rawhide/ci.html > >> http://sssd-ci.duckdns.org/logs/job/14/07/fedora_rawhide/ci.html > >> http://sssd-ci.duckdns.org/logs/job/14/97/debian_testing/ci.html > >> > >> Attached patch should fix race condition between two SSSDConfigTest tests. > >> The problem is just in master due to python{2,3} changes. > >> > >> LS > > > >The intent is good, but I would prefer using the setUp() and tearDown() > >methods for creating and removing the directory. > I wanted to left temp dir for analysis, > but code is stable and in case of problem it's easy > to debug with "python -m pdb" > > >It's safe because the Python documentation says: > > If setUp() succeeded, the tearDown() method will be run whether > > runTest() succeeded or not. > Updated version of attached. > > LS
I didn't reproduce the failure, but the code now looks good to me and the tests pass. ACK _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
