Hello,

please see simple patch attached.

Thanks!
>From 1dd2599ccdef13adb4d8f7a70c62e2a96942127e Mon Sep 17 00:00:00 2001
From: Pavel Reichl <prei...@redhat.com>
Date: Thu, 3 Sep 2015 04:46:50 -0400
Subject: [PATCH] GPO: fix memory leak

Resolves:
https://fedorahosted.org/sssd/ticket/2777
---
 src/providers/ad/ad_gpo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c
index ffd8ac5dd15233788b254cd00a19b5dfc4d127d1..12632e56e5f640787b12ae6ac0ce738f5d6e828b 100644
--- a/src/providers/ad/ad_gpo.c
+++ b/src/providers/ad/ad_gpo.c
@@ -560,14 +560,14 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx,
         DEBUG(SSSDBG_OP_FAILURE,
               "sysdb_initgroups failed: [%d](%s)\n",
               ret, sss_strerror(ret));
-        return ret;
+        goto done;
     }
 
     if (res->count == 0) {
         ret = ENOENT;
         DEBUG(SSSDBG_OP_FAILURE,
               "sysdb_initgroups returned empty result\n");
-        return ret;
+        goto done;
     }
 
     user_sid = ldb_msg_find_attr_as_string(res->msgs[0], SYSDB_SID_STR, NULL);
@@ -602,7 +602,7 @@ ad_gpo_get_sids(TALLOC_CTX *mem_ctx,
     *_group_size = num_group_sids + 1;
     *_group_sids = talloc_steal(mem_ctx, group_sids);
     *_user_sid = talloc_steal(mem_ctx, user_sid);
-    return EOK;
+    ret = EOK;
 
  done:
     talloc_free(tmp_ctx);
-- 
2.4.3

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to