On 09/29/2015 05:13 PM, Nikolai Kondrashov wrote:
On 09/29/2015 03:54 PM, Lukas Slebodnik wrote:
ehlo,

I touched the CI script and I found an interesting todo

distro.sh-52-{
distro.sh-53-    declare prompt=$'Need root permissions to install packages.\n'
distro.sh-54-    prompt+="Enter sudo password for $USER: "
distro.sh-55-    if [[ "$DISTRO_BRANCH" == -redhat-* ]]; then
distro.sh-56-        [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install -- 
"$@" |&
distro.sh-57-            # Pass input to output, fail if a missing package is 
reported
distro.sh-58-            # TODO Remove and switch to DNF once
distro.sh:59:            # https://bugzilla.redhat.com/show_bug.cgi?id=1128139 
is fixed
distro.sh-60-            awk 'BEGIN {s=0}
distro.sh-61-                 /^No package .* available.$/ {s=1}
distro.sh-62-                 {print}
distro.sh-63-                 END {exit s}'
distro.sh-64-    elif [[ "$DISTRO_BRANCH" == -debian-* ]]; then
distro.sh-65-        [ $# != 0 ] && sudo -p "$prompt" apt-get --yes install -- 
"$@"
distro.sh-66-    else


The BZ1128139 was closed as duplicate of BZ1107737.
The BZ1107737 was fixed 7 months ago and is available in
dnf >= 0.6.4-2. The Fedora 21 currently have dnf-0.6.4-7.
I think it's the best time for removing this todo.

I would very much like to get rid of it, but unfortunately we're blocked by
this DNF bug here:

     https://bugzilla.redhat.com/show_bug.cgi?id=1215208

Due to this bug we still have to use yum-deprecated on Fedora Rawhide (by
modifying /usr/bin/yum to invoke yum-deprecated instead of dnf) and the bug
mentioned in the TODO wasn't and likely won't be fixed in yum.

So, I think we can only update the bug number for now. The patch is attached.

Nick
>From e8fc55e0674bdd20fd101a70e50f1d9f58db510d Mon Sep 17 00:00:00 2001
From: Nikolai Kondrashov <nikolai.kondras...@redhat.com>
Date: Tue, 29 Sep 2015 17:34:32 +0300
Subject: [PATCH] CI: Update reason blocking move to DNF

---
 contrib/ci/distro.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/ci/distro.sh b/contrib/ci/distro.sh
index 5416bff..7db1794 100644
--- a/contrib/ci/distro.sh
+++ b/contrib/ci/distro.sh
@@ -54,7 +54,7 @@ function distro_pkg_install()
         [ $# != 0 ] && sudo -p "$prompt" yum --assumeyes install -- "$@" |&
             # Pass input to output, fail if a missing package is reported
             # TODO Remove and switch to DNF once
-            # https://bugzilla.redhat.com/show_bug.cgi?id=1128139 is fixed
+            # https://bugzilla.redhat.com/show_bug.cgi?id=1215208 is fixed
             awk 'BEGIN {s=0}
                  /^No package .* available.$/ {s=1}
                  {print}
-- 
2.5.1

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to