On Wed, Oct 14, 2015 at 12:52:38PM +0200, Sumit Bose wrote: > On Wed, Oct 14, 2015 at 12:27:12PM +0200, Jakub Hrozek wrote: > > On Wed, Oct 14, 2015 at 11:29:09AM +0200, Pavel Březina wrote: > > > On 10/13/2015 03:51 PM, Jakub Hrozek wrote: > > > >On Tue, Oct 13, 2015 at 12:08:22PM +0200, Pavel Březina wrote: > > > >>>I don't like overriding opt_name and opt_id here, the caller of > > > >>>check_cache() does not expect that those values change (especially > > > >>>because opt_name is declared const in the header). Additionally I'm not > > > >> > > > >>The values won't change in the caller of check_cache. > > > > > > > >But it's still really bad taste to change input parameters, can we have > > > >a separate variable we assign to? > > > > > > Ok, new patches are attached. > > > > > Thank you Pavel, ACK from me as well. > > bye, > Sumit
CI: http://sssd-ci.duckdns.org/logs/job/30/27/summary.html Coverity was happy as well. * master: * 2f793681b4debbe015815f908dc12c0463711609 * 51a0e3a2ef9186d19cbc28d87fe6fc5d5998a0a7 * fb8985a3a3a267940760967beaf8af3979ce91ea * sssd-1-13: * 2a5c268f66844a65447a814fd48644768238b307 * 6e3fa032485e8a107d32c6f4978b4dead6118114 * 329ea3541799d2abb5f0cdb73c24153b9892148b _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
