On Fri, Mar 11, 2016 at 10:07:16AM +0100, Lukas Slebodnik wrote: > On (10/03/16 20:37), Lukas Slebodnik wrote: > >On (10/03/16 20:02), Jakub Hrozek wrote: > >>On Thu, Mar 10, 2016 at 12:53:44PM +0100, Lukas Slebodnik wrote: > >>> diff --git a/Makefile.am b/Makefile.am > >>> index d6eb0fc..f8111d0 100644 > >>> --- a/Makefile.am > >>> +++ b/Makefile.am > >>> @@ -946,6 +946,10 @@ libipa_hbac_la_DEPENDENCIES = > >>> src/providers/ipa/ipa_hbac.exports > >>> libipa_hbac_la_SOURCES = \ > >>> src/providers/ipa/hbac_evaluator.c \ > >>> src/util/sss_utf8.c > >>> +libipa_hbac_la_CFLAGS = \ > >>> + $(AM_CFLAGS) \ > >>> + -std=c90 \ > Actually we shoudl use "-std=c89" > becuase gcc on rhel6 does not have "c90" > > It has only: > c89 > iso9899:1990 > Support all ISO C90 programs (certain GNU extensions that > conflict with ISO C90 are disabled). Same as -ansi for C code. > > iso9899:199409 > ISO C90 as modified in amendment 1. > > c99 > c9x > iso9899:1999 > iso9899:199x > ISO C99. Note that this standard is not yet fully supported; > see <http://gcc.gnu.org/gcc-4.4/c99status.html> for more > information. The names c9x and iso9899:199x are deprecated. > > and c9x might be to new :-) > or we might use "iso9899:1990" if "c89" will be too complicated.
Yeah, CI already kicked me out when I submitted the patch with -std=c90 :-) _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
