Hi, this is a follow-up patch to 5a5f1e1053415efaa99bb4d5bc7ce7ac0a95b757 which removes another call to ipa_check_master() which might cause an infinite loop on an IPA client if the server does not support views.
Please note that this patch is a different one than the one I used for the first test build in https://bugzilla.redhat.com/show_bug.cgi?id=1328108. See comment #12 for details. bye, Sumit
From 1e052649e15f5830ffbc6ba0dc4a78c49a3a95ba Mon Sep 17 00:00:00 2001 From: Sumit Bose <sb...@redhat.com> Date: Tue, 19 Apr 2016 15:07:18 +0200 Subject: [PATCH] IPA: terminate properly if view name lookup fails Since commit 5a5f1e1053415efaa99bb4d5bc7ce7ac0a95b757 the view name lookup is the last step in the subdomain lookup request. In case of an error the request should be finished and no previous step should be called again. Resolves https://fedorahosted.org/sssd/ticket/2993 --- src/providers/ipa/ipa_subdomains.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/providers/ipa/ipa_subdomains.c b/src/providers/ipa/ipa_subdomains.c index bcc6347fa0c53939bb60cff2e903e1db6e2bb6b6..bfe770be6f8c94478baecd1bb88cedc222586187 100644 --- a/src/providers/ipa/ipa_subdomains.c +++ b/src/providers/ipa/ipa_subdomains.c @@ -840,13 +840,7 @@ static void ipa_get_view_name_done(struct tevent_req *req) if (ret == EOPNOTSUPP || ret == EIO) { DEBUG(SSSDBG_TRACE_FUNC, "get_view_name request failed, looks " \ "like server does not support views.\n"); - ret = ipa_check_master(ctx); - if (ret == EAGAIN) { - return; - } else if (ret != EOK) { - goto done; - } - + ret = EOK; } else { DEBUG(SSSDBG_OP_FAILURE, "get_view_name request failed.\n"); } -- 2.1.0
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
