On Wed, May 04, 2016 at 11:36:57PM +0200, Lukas Slebodnik wrote: > On (27/04/16 10:51), Jakub Hrozek wrote: > >Hi, > > > >the attached patches implement unit tests for the pam_sss module using > >pam_wrapper and libpamtest. In my testing, the coverage is around 75% > >with mostly the parts that require running as root being untested. > > > >I worked on this patchset even though the features for 1.14 are in full > >swing because there are several tickets that will require us to patch > >pam_sss, so it's important to have the code that changes tested. In > >addition, when we merge Dan's patches to use TLS with integration tests, > >then we'll be able to also test authentication in integration tests > >easily using libpamtest-python. > > > >However, our CI fails for me constantly: > > http://sssd-ci.duckdns.org/logs/job/42/75/fedora_rawhide/ci.html > >The strange thing is that running CI locally works fine and so does make > >check. Can anyone help point me in the right direction as to what should > >I check next? I suspect some of the environment variables might not be > >set correctly, but I don't see why.. > > Are you sure it pass locally with valgrind? > > It failed because there are valgrind errors. > I can see then on fedora 22 and fedora 23 > http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora22/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.1444.valgrind.log > http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora22/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.log > > I cannot see them on fedora 24 or fedora rawhide > http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora_rawhide/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.10504.valgrind.log > but it fails as well > http://sssd-ci.duckdns.org/logs-test/job/2/70/fedora_rawhide/ci-build-debug/src/tests/cwrap/pam_sss-tests.sh.log > > If the problem is with missing environment variables > then you might log all environment variables in main function
just a quick update: the issues in tests were resolved. I hit two bugs in pam_wrapper: https://github.com/jhrozek/pam_wrapper/commit/ff7ec1c5ea7ed2360cbc59bd58f9caae7c9fa53d https://github.com/jhrozek/pam_wrapper/commit/c9b11ac8947bc0ff2ec3c4140b4d7413bfaadb37 so once Andreas approves them, I will build a new pam_wrapper RPM for Fedora and EPEL so that we can formally review the pam_sss test patches. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org