On (08/07/16 15:14), Michal Židek wrote:
>On 07/08/2016 12:56 PM, Lukas Slebodnik wrote:
>> On (08/07/16 12:17), Michal Židek wrote:
>> > From 66419775a94768efe8c98ce6e8bbfa4743107eae Mon Sep 17 00:00:00 2001
>> > From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzi...@redhat.com>
>> > Date: Fri, 8 Jul 2016 11:32:50 +0200
>> > Subject: [PATCH] config: Some fixes to schema
>> > 
>> > Fixes:
>> > https://fedorahosted.org/sssd/ticket/3068
>> > 
>> > Option "timeout" must be allowed for all
>> > responders.
>> > Option "user_attributes" is
>> > also available in NSS responder.
>> > Option override_space is read from monitor
>> > section, not NSS.
>> > ---
>> > src/config/cfg_rules.ini     | 10 +++++++++-
>> > src/config/etc/sssd.api.conf | 10 +++++++++-
>> > 2 files changed, 18 insertions(+), 2 deletions(-)
>> > 
>> > diff --git a/src/config/etc/sssd.api.conf b/src/config/etc/sssd.api.conf
>> > index 9114659..03e5a72 100644
>> > --- a/src/config/etc/sssd.api.conf
>> > +++ b/src/config/etc/sssd.api.conf
>> > @@ -28,9 +28,12 @@ krb5_rcache_dir = str, None, false
>> > user = str, None, false
>> > default_domain_suffix = str, None, false
>> > certificate_verification = str, None, false
>> > +override_space = str, None, false
>> // snip
>> > 
>> > [ifp]
>> > # InfoPipe responder
>> > +timeout = int, None, false
>> IMHO, it would be better to add it to the section
>> "[service]" The same as debug_level.
>> We would avoid some duplication
>> 
>> LS
>
>new patch attached. There was one more error
>with the PAC responder and user_attributes
>option.
>

I found another issue with schema.
there are warnings if sssd.conf explicitly
contains "config_file_version = 2"

BTW patch looks like a snow ball.
It might be a good idea to split it (at least partially)

LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

Reply via email to