On (30/08/16 13:13), Pavel Březina wrote:
>On 08/05/2016 05:24 PM, Lukas Slebodnik wrote:
>> On (04/08/16 14:11), Pavel Březina wrote:
>> > Simple one liner attached.
>>
>> > From 6c3d8d6dba969960590d88bdd9a4ec2e9b4a1bb2 Mon Sep 17 00:00:00 2001
>> > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com>
>> > Date: Thu, 4 Aug 2016 14:10:09 +0200
>> > Subject: [PATCH] Fix typo in debug message
>> >
>> > ---
>> > src/providers/ipa/ipa_init.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
>> > index
>> > ca99200a1ba1d9508ac0affffecaa08149552fee..7dec4d1fb8541a48470d4e44f10838e5bea67ad5
>> > 100644
>> > --- a/src/providers/ipa/ipa_init.c
>> > +++ b/src/providers/ipa/ipa_init.c
>> > @@ -200,7 +200,7 @@ static errno_t ipa_init_dyndns(struct be_ctx *be_ctx,
>> > enabled = dp_opt_get_bool(ipa_options->dyndns_ctx->opts,
>> > DP_OPT_DYNDNS_UPDATE);
>> > if (!enabled) {
>> > - DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates are of.\n");
>> > + DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates are off.\n");
>>
>> It would be good to have the same message as in ad provider.
>> Or change it also there :-)
>>
>> sh$ git grep "Dynamic DNS updates"
>> src/config/cfg_rules.ini:# Dynamic DNS updates
>> src/config/etc/sssd.api.conf:# Dynamic DNS updates
>> src/providers/ad/ad_common.h: /* Dynamic DNS updates */
>> src/providers/ad/ad_dyndns.c: DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic
>> DNS updates not set\n");
>> src/providers/ad/ad_dyndns.c: "Dynamic DNS updates are on. Checking
>> for nsupdate..\n");
>> src/providers/be_dyndns.c: "%s does not exist. Dynamic DNS
>> updates disabled\n",
>> src/providers/ipa/ipa_init.c: DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic
>> DNS updates are of.\n");
>> src/providers/ipa/ipa_init.c: "Dynamic DNS updates are on. Checking
>> for nsupdate...\n");
>>
>> LS
>> _______________________________________________
>> sssd-devel mailing list
>> sssd-devel@lists.fedorahosted.org
>> https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
>>
>
>From 40850397be1e8be3b38437a6a93f4c1772c2f6af Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrez...@redhat.com>
>Date: Thu, 4 Aug 2016 14:10:09 +0200
>Subject: [PATCH] dyndns: fix typo and unify ipa with ad debug message when off
>
>---
> src/providers/ad/ad_dyndns.c | 2 +-
> src/providers/ipa/ipa_init.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/providers/ad/ad_dyndns.c b/src/providers/ad/ad_dyndns.c
>index
>e3f1812837f7cee9d18ef001233871e0fcc16b4c..00190485e8f0ca7362ed60b2df022c74c53988c9
> 100644
>--- a/src/providers/ad/ad_dyndns.c
>+++ b/src/providers/ad/ad_dyndns.c
>@@ -47,7 +47,7 @@ errno_t ad_dyndns_init(struct be_ctx *be_ctx,
>
> if (dp_opt_get_bool(ad_opts->dyndns_ctx->opts,
> DP_OPT_DYNDNS_UPDATE) == false) {
>- DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates not set\n");
>+ DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates are off.\n");
> return EOK;
> }
>
>diff --git a/src/providers/ipa/ipa_init.c b/src/providers/ipa/ipa_init.c
>index
>ca99200a1ba1d9508ac0affffecaa08149552fee..7dec4d1fb8541a48470d4e44f10838e5bea67ad5
> 100644
>--- a/src/providers/ipa/ipa_init.c
>+++ b/src/providers/ipa/ipa_init.c
>@@ -200,7 +200,7 @@ static errno_t ipa_init_dyndns(struct be_ctx *be_ctx,
> enabled = dp_opt_get_bool(ipa_options->dyndns_ctx->opts,
> DP_OPT_DYNDNS_UPDATE);
> if (!enabled) {
>- DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates are of.\n");
>+ DEBUG(SSSDBG_CONF_SETTINGS, "Dynamic DNS updates are off.\n");
> return EOK;
ACK
LS
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
