On (12/09/16 10:23), Petr Cech wrote: >On 09/12/2016 10:01 AM, Lukas Slebodnik wrote: >> > You have a point here (and I regret adding the ENOENT retval in general, >> > >but the difference is that ldb_search wrapper changes /functionality/, >> > >this >> > >just adds logging. So the only thing we would miss if we forget to use >> > >the wrapper is the extra debugging. And in that case we would have to >> > >build a new package and commit the messages to master, but that's no >> > >different from missing debug messages in general. >> > > >> Inconsistencies are bad. it does not matter wheter it's about ENOENT >> or logging. > >Hi Lukas, > >if you are afraid of inconsistency in using wrappers at all places in code I >think I could prepare test which say you that you should write sss_ldb_* >instead od ldb_*. > You would need to write a plugin to compiler + linker to be 100% sure. Or you can write logging feature to the libldb.
I already wrote in previous mails. Wrappers are bad. I am fine with using wrappers for developer porposes or for testing builds. LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
