URL: https://github.com/SSSD/sssd/pull/57
Title: #57: LDAP/AD: resolve domain local groups for remote users
jhrozek commented:
"""
Hmm, looks like github ate my mail, so let's paste the comment again (and sorry
if it arrives twice). Coverity detected some warnings:
```
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1554:12: warning:
unused variable 'd' [-Wunused-variable]
# size_t d;
# ^
# 1552| int ret;
# 1553| size_t c;
# 1554|-> size_t d;
# 1555| char **groupnamelist = NULL;
# 1556| struct sysdb_attrs *groups[1];
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1562:25: warning:
unused variable 'msg' [-Wunused-variable]
# struct ldb_message *msg;
# ^
# 1560| const char *class;
# 1561| struct sss_domain_info *obj_dom;
# 1562|-> struct ldb_message *msg;
# 1563| struct ldb_message_element *el;
# 1564| const char *obj_attrs[] = {SYSDB_NAME, SYSDB_MEMBEROF, NULL};
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1563:33: warning:
unused variable 'el' [-Wunused-variable]
# struct ldb_message_element *el;
# ^
# 1561| struct sss_domain_info *obj_dom;
# 1562| struct ldb_message *msg;
# 1563|-> struct ldb_message_element *el;
# 1564| const char *obj_attrs[] = {SYSDB_NAME, SYSDB_MEMBEROF, NULL};
# 1565| char *local_groups_base_dn;
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1564:17: warning:
unused variable 'obj_attrs' [-Wunused-variable]
# const char *obj_attrs[] = {SYSDB_NAME, SYSDB_MEMBEROF, NULL};
# ^
# 1562| struct ldb_message *msg;
# 1563| struct ldb_message_element *el;
# 1564|-> const char *obj_attrs[] = {SYSDB_NAME, SYSDB_MEMBEROF, NULL};
# 1565| char *local_groups_base_dn;
# 1566| uint8_t *obj_base_dn;
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1566:14: warning:
unused variable 'obj_base_dn' [-Wunused-variable]
# uint8_t *obj_base_dn;
# ^
# 1564| const char *obj_attrs[] = {SYSDB_NAME, SYSDB_MEMBEROF, NULL};
# 1565| char *local_groups_base_dn;
# 1566|-> uint8_t *obj_base_dn;
# 1567| char **cached_local_parents = NULL;
# 1568| uint8_t *name_start;
Error: COMPILER_WARNING:
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c: scope_hint: In
function 'sdap_ad_get_domain_local_groups_parse_parents'
sssd-1.14.90/src/providers/ldap/sdap_async_initgroups_ad.c:1568:14: warning:
unused variable 'name_start' [-Wunused-variable]
# uint8_t *name_start;
# ^
# 1566| uint8_t *obj_base_dn;
# 1567| char **cached_local_parents = NULL;
# 1568|-> uint8_t *name_start;
# 1569| char **add_list = NULL;
# 1570| char **del_list = NULL;
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/57#issuecomment-255322943
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
