URL: https://github.com/SSSD/sssd/pull/78 Author: mzidek-rh Title: #78: ipa: Nested netgroups do not work Action: opened
PR body: """ We lowercase the keys to the hash table used to store netgroups but do not lowercase it when reading the table. This results in nested netgroups not being found when they should and the processing fails. The lowercasing does not seem to be necessary anymore (not sure if it ever was) so we can skip it. Resolves: https://fedorahosted.org/sssd/ticket/3159 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/78/head:pr78 git checkout pr78
From e736c0f9bdd778bef04341e3aa33ea0e5a426a52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= <mzi...@redhat.com> Date: Thu, 10 Nov 2016 15:04:57 +0100 Subject: [PATCH] ipa: Nested netgroups do not work We lowercase the keys to the hash table used to store netgroups but do not lowercase it when reading the table. This results in nested netgroups not being found when they should and the processing fails. The lowercasing does not seem to be necessary anymore (not sure if it ever was) so we can skip it. Resolves: https://fedorahosted.org/sssd/ticket/3159 --- src/providers/ipa/ipa_netgroups.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/providers/ipa/ipa_netgroups.c b/src/providers/ipa/ipa_netgroups.c index a19e5e0..17b11af 100644 --- a/src/providers/ipa/ipa_netgroups.c +++ b/src/providers/ipa/ipa_netgroups.c @@ -563,7 +563,6 @@ static void ipa_netgr_members_process(struct tevent_req *subreq) size_t count; int ret, i; const char *orig_dn; - char *orig_dn_lower; hash_table_t *table; hash_key_t key; hash_value_t value; @@ -638,20 +637,12 @@ static void ipa_netgr_members_process(struct tevent_req *subreq) goto fail; } - orig_dn_lower = talloc_strdup(table, orig_dn); - if (orig_dn_lower == NULL) { + key.str = talloc_strdup(table, orig_dn); + if (key.str == NULL) { ret = ENOMEM; goto fail; } - /* Transform the DN to lower case. - * this is important, as the member/memberof attributes - * have the value also in lower-case - */ - key.str = orig_dn_lower; - while (*orig_dn_lower != '\0') { - *orig_dn_lower = tolower(*orig_dn_lower); - orig_dn_lower++; - } + value.ptr = entities[i]; ret = hash_enter(table, &key, &value); if (ret != HASH_SUCCESS) {
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
