URL: https://github.com/SSSD/sssd/pull/50 Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented: """ So, here are some stats about the configure time that you complained before: So, I've ran the contrib/ci/run script on our F25 machine on Jenkins. This is what we have **without** GNULIB patch: ``` -bash-4.3$ ./contrib/ci/run install-deps: success 00:00:05 ci-install-deps.log autoreconf: success 00:00:22 ci-autoreconf.log DEBUG BUILD: ci-build-debug configure: success 00:00:16 ci-build-debug/ci-configure.log make-tests: success 00:02:55 ci-build-debug/ci-make-tests.log make-check-valgrind: success 00:01:33 ci-build-debug/ci-make-check-valgrind.log SUCCESS ``` And this is what we have **with** GNULIB patch applied: ``` -bash-4.3$ ./contrib/ci/run install-deps: success 00:00:05 ci-install-deps.log autoreconf: success 00:00:23 ci-autoreconf.log DEBUG BUILD: ci-build-debug configure: success 00:00:22 ci-build-debug/ci-configure.log make-tests: success 00:03:56 ci-build-debug/ci-make-tests.log make-check-valgrind: success 00:01:33 ci-build-debug/ci-make-check-valgrind.log SUCCESS ``` It adds 6 seconds more to the configure time. I really think that dropping those patches because of 6 seconds on the configure is far, but really really, far away from being reasonable. So, can we have the patches reviewed and merged? """ See the full comment at https://github.com/SSSD/sssd/pull/50#issuecomment-259738984
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
