URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple
lslebodn commented: """ This is only a problem with strict warning flags. which is usually a develer build. There is not a problem in downstream centos/fedora ->see https://kojipkgs.fedoraproject.org//packages/sssd/1.14.2/1.fc24/data/logs/x86_64/build.log ``` checking sys/inotify.h usability... yes checking sys/inotify.h presence... yes checking for sys/inotify.h... yes checking whether sys/inotify.h actually works... yes ``` And more verbose version: ``` configure:25860: checking sys/inotify.h usability configure:25860: gcc -c -g -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE conftest.c >&5 configure:25860: $? = 0 configure:25860: result: yes configure:25860: checking sys/inotify.h presence configure:25860: gcc -E conftest.c configure:25860: $? = 0 configure:25860: result: yes configure:25860: checking for sys/inotify.h configure:25860: result: yes configure:25871: checking whether sys/inotify.h actually works configure:25883: gcc -o conftest -g -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE conftest.c >&5 conftest.c: In function 'main': conftest.c:186:19: warning: implicit declaration of function 'inotify_init' [-Wimplicit-function-declaration] return (-1 == inotify_init()); ^~~~~~~~~~~~ configure:25883: $? = 0 configure:25884: result: yes ``` Anyway, have you tested your patch? I can still see issue there. ``` configure:25883: gcc -o conftest -g -O2 -ftrack-macro-expansion=0 -Wextra -Wno-unused-parameter -Wno-sign-compare -Werror -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -Wl,--as-needed conftest.c >&5 conftest.c:183:25: error: extra tokens at end of #include directive [-Werror] #include <sys/inotify.h>, ^ cc1: all warnings being treated as errors configure:25883: $? = 1 ``` LS """ See the full comment at https://github.com/SSSD/sssd/pull/81#issuecomment-261513452
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
