This patch is OK, but only for sssd-1-14. In master, we already fall back to parsing the name string as short name if parsing the qualified name fails. I’m not thrilled about that, because it can conceal legitimate errors, but it’s needed atm to use cache_req everywhere.
So yeah, ack to this patch for sssd-1-14. > On 6 Jan 2017, at 10:59, lslebodn <sssd-github-notificat...@fedorahosted.org> > wrote: > > URL: https://github.com/SSSD/sssd/pull/109 > Title: #109: SSSCTL: fix netgroup-show parsing > > lslebodn commented: > """ > @jhrozek Have you already decided whether it would be better to have this > patch or 7b293a5? > """ > > See the full comment at > https://github.com/SSSD/sssd/pull/109#issuecomment-270870268 > _______________________________________________ > sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org > To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org _______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
