URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders
fidencio commented: """ On Fri, Jan 13, 2017 at 11:42 AM, Jakub Hrozek <notificati...@github.com> wrote: > *@jhrozek* commented on this pull request. > ------------------------------ > > In src/util/util.c > <https://github.com/SSSD/sssd/pull/94#pullrequestreview-16544855>: > > > @@ -1277,3 +1279,12 @@ bool is_user_or_group_name(const char > > *sudo_user_value) > /* Now it's either a username or a groupname */ > return true; > } > + > +bool is_socket_activated(void) > +{ > +#ifdef HAVE_SYSTEMD > + return !!socket_activated; > > Why the double negative here? is it converting int to bool? > That's exactly the case. I may be mistaken in the way I implemented it, but the value get from the command line i stored as an int and on this function I'm just return true/flase indicating wthether the service was socket-activated. I'm not sure if I can just store the command line option as a bool, but I've seen it's not done with other bool command options (as debug-to-files, per example). > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/SSSD/sssd/pull/94#pullrequestreview-16544855>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAG4erwga9z_fz0fLj9nQXaIQ_xAurnpks5rR1T8gaJpZM4K8AJs> > . > """ See the full comment at https://github.com/SSSD/sssd/pull/94#issuecomment-272415634
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
