URL: https://github.com/SSSD/sssd/pull/190 Author: lslebodn Title: #190: Few unit tests for recent contribution from community Action: opened
PR body: """ """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/190/head:pr190 git checkout pr190
From d5fba7429abe82503cf51706bc6a85d737bafcb8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Tue, 7 Mar 2017 21:53:04 +0100 Subject: [PATCH 1/2] test_utils: Add test coverage for %l in override_homedir Related-to: https://pagure.io/SSSD/sssd/issue/2668 --- src/tests/cmocka/test_utils.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/tests/cmocka/test_utils.c b/src/tests/cmocka/test_utils.c index 0927369..7928795 100644 --- a/src/tests/cmocka/test_utils.c +++ b/src/tests/cmocka/test_utils.c @@ -41,6 +41,7 @@ #define STR(tok) MACRO_EXPAND(tok) #define USERNAME "sssduser" +#define FIRST_LETTER "s" #define UID 1234 #define DOMAIN "sssddomain" #define ORIGINAL_HOME "/home/user" @@ -1217,12 +1218,18 @@ void test_expand_homedir_template(void **state) check_expanded_value(tmp_ctx, homedir_ctx, DUMMY"%%"DUMMY2, DUMMY"%"DUMMY2); + check_expanded_value(tmp_ctx, homedir_ctx, "%l", FIRST_LETTER); + check_expanded_value(tmp_ctx, homedir_ctx, DUMMY"%l", DUMMY FIRST_LETTER); + check_expanded_value(tmp_ctx, homedir_ctx, "%l"DUMMY, FIRST_LETTER DUMMY); + check_expanded_value(tmp_ctx, homedir_ctx, DUMMY"%l"DUMMY2, + DUMMY FIRST_LETTER DUMMY2); + /* test all format strings */ check_expanded_value(tmp_ctx, homedir_ctx, - DUMMY"/%u/%U/%d/%f/%o/%F/%%/%H/"DUMMY2, + DUMMY"/%u/%U/%d/%f/%o/%F/%%/%H/%l/"DUMMY2, DUMMY"/"USERNAME"/" STR(UID) "/"DOMAIN"/" USERNAME"@"DOMAIN"/"ORIGINAL_HOME"/"FLATNAME"/%/" - HOMEDIR_SUBSTR"/"DUMMY2); + HOMEDIR_SUBSTR"/"FIRST_LETTER"/"DUMMY2); talloc_free(tmp_ctx); } From 4c485de9895879b6d100ad4a97c02b60cf9e1685 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Tue, 7 Mar 2017 20:56:59 +0100 Subject: [PATCH 2/2] util-test: Extend unit test for sss_filter_sanitize_ex Related-to: https://pagure.io/SSSD/sssd/issue/3317 --- src/tests/util-tests.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/tests/util-tests.c b/src/tests/util-tests.c index df4cf96..ae2577f 100644 --- a/src/tests/util-tests.c +++ b/src/tests/util-tests.c @@ -415,6 +415,24 @@ START_TEST(test_sss_filter_sanitize) "Expected [%s], got [%s]", has_all_expected, sanitized); + const char has_new_line[] = "user\nname"; + const char has_new_line_expected[] = "user\\0aname"; + ret = sss_filter_sanitize(test_ctx, has_new_line, &sanitized); + fail_unless(ret == EOK, "has_new_line error [%d][%s]", + ret, strerror(ret)); + fail_unless(strcmp(has_new_line_expected, sanitized) == 0, + "Expected [%s], got [%s]", + has_new_line_expected, sanitized); + + const char has_carriage_ret[] = "user\rname"; + const char has_carriage_ret_expected[] = "user\\0dname"; + ret = sss_filter_sanitize(test_ctx, has_carriage_ret, &sanitized); + fail_unless(ret == EOK, "has_carriage_ret error [%d][%s]", + ret, strerror(ret)); + fail_unless(strcmp(has_carriage_ret_expected, sanitized) == 0, + "Expected [%s], got [%s]", + has_carriage_ret_expected, sanitized); + talloc_free(test_ctx); } END_TEST
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
