URL: https://github.com/SSSD/sssd/pull/186 Title: #186: Subdomain config
jhrozek commented: """ > On 10 Mar 2017, at 11:47, mzidek-rh <notificati...@github.com> wrote: > > Hi, I respond to your comments in the review in this comment, so that you get > notification :) > > About the condition with cdb and conf_path being NULL. You are right that > this can not happen in the SSSD code and is (half) dead code and I do plan to > delete it, but not immediately. Some of our cmocka tests rely on this > function (they use it to set up the defaults and then run 1way/2way trust > init unit tests). I had trouble when rewriting the tests, so I decided to > keep it there for now. > > About server and site. Yes I plan to add that too, but it will be separate > patch, not new version of the patches I sent. It is still not testable so I > wanted to get at least this part out. > > About what options will be supported. Yes it is possible to set more options > with this patch. But I was not sure if we want to support all possible cases, > so I decided to only document those. My concern is that we would need to > support those forever, so I would prefer to have a solid use case behind > every such option. > > Yeah, all options don’t make sense in all cases. And I think it’s better to only document, test and support a subset, as long as the code is built generically so it’s easy to extend. """ See the full comment at https://github.com/SSSD/sssd/pull/186#issuecomment-285642341
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
