URL: https://github.com/SSSD/sssd/pull/327 Title: #327: RESPONDERS: Fix terminating idle connections
jhrozek commented: """ On Thu, Jul 20, 2017 at 08:46:04AM +0000, lslebodn wrote: > On (20/07/17 08:03), Jakub Hrozek wrote: > >> A) It is not clear because it is not documented. > > > >I can submit a PR that fixes the manpage, but it suprises me that you're > >still surprised that our documentation is missing something :) > > > > I consider integration test as an additional documentation. > It was not clear to me why we used such values in the test. > That's the first problem. So I tried to check man page. > And it didn't help either. > > >> B) I do not see a reason why minimal value have to be 10 seconds. > >> why not 11, 13, 17, 19 or any other value. > > > >Because I wasn't sure if 11 wouldn't cause false positives (which > >ultimately waste more time b/c someone has to look at them) > > > >But if you prefer, I can lower that to 11. I can't lower that below 10 > >though. > Use whatever value would work reliably but at least document why > you used such hardcoded value. People tend to forget and we might > not know in future why such value was used and whether it can be changed. > > And I still would prefer faster test. But that can be done after 1.15.3 Feel free to file a ticket to remove this limitation in tests. But I think for real-world, the 10 seconds minimum makes sense (even though, we probably shouldn't try to protect our users from shooting themselves in the foot /too hard/..) """ See the full comment at https://github.com/SSSD/sssd/pull/327#issuecomment-316639773
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
