URL: https://github.com/SSSD/sssd/pull/334 Author: amitkumar50 Title: #334: Print a warning when enumeration is requested but disabled Action: opened
PR body: """ Purpose of this PR is to add an explanatory message to be logged once at the start-up explaning that if enumeration is off 'getent passwd' will not return all users information. This is by design. Again Log level for this message it kept low [SSSDBG_OP_FAILURE 0x0040 /* level 2 */]. We want this message to be printed in almost all cases because it tells this functionality is be design and prevents anyone from opening a bug. Resolves: https://pagure.io/SSSD/sssd/issue/2301 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/334/head:pr334 git checkout pr334
From 5c7cf2caaaef2b378ef88c7487389db45dc01da5 Mon Sep 17 00:00:00 2001 From: AmitKumar <amitk...@redhat.com> Date: Mon, 24 Jul 2017 20:15:13 +0530 Subject: [PATCH] Print a warning when enumeration is requrested but disabled Purpose of this PR is to add an explanatory message to be logged once at the start-up explaning that if enumeration is off 'getent passwd' will not return all users information. This is by design. Again Log level for this message it kept low [SSSDBG_OP_FAILURE 0x0040 /* level 2 */]. We want this message to be printed in almost all cases because it tells this functionality is be design and prevents anyone from opening a bug. Resolves: https://pagure.io/SSSD/sssd/issue/2301 --- src/confdb/confdb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c index 286dbb243..4aaa8c08b 100644 --- a/src/confdb/confdb.c +++ b/src/confdb/confdb.c @@ -1010,6 +1010,9 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb, if (!domain->enumerate) { DEBUG(SSSDBG_TRACE_FUNC, "No enumeration for [%s]!\n", domain->name); + DEBUG(SSSDBG_OP_FAILURE, "Please note With No enumeration sssd " + "getent passwd does not return all users by design, see man " + "pages for more information\n"); } ret = confdb_get_string(cdb, tmp_ctx, CONFDB_MONITOR_CONF_ENTRY,
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
