[SSSD] [sssd PR#241][comment] FleetCommander Integration

[fidencio]

  URL: https://github.com/SSSD/sssd/pull/241
Title: #241: FleetCommander Integration

fidencio commented:
"""
Patch set updated.

This is the patch that I've squashed:
```
From 97f189d3a4fcbbfe453cc6ba8eab8710ca31c4ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fiden...@redhat.com>
Date: Thu, 17 Aug 2017 13:29:24 +0200
Subject: [PATCH] fixup! DESKPROFILE: Introduce the new IPA session provider

---
 src/providers/ipa/ipa_deskprofile_rules_util.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/providers/ipa/ipa_deskprofile_rules_util.c 
b/src/providers/ipa/ipa_deskprofile_rules_util.c
index 12c6492ba..2ece5a1ee 100644
--- a/src/providers/ipa/ipa_deskprofile_rules_util.c
+++ b/src/providers/ipa/ipa_deskprofile_rules_util.c
@@ -150,7 +150,7 @@ ipa_deskprofile_get_filename_path(TALLOC_CTX *mem_ctx,
         extension,
         NULL,
     };
-    const uint8_t *perms = permuts[config_priority - 1];
+    const uint8_t *perms;
     char *result;
     errno_t ret;
 
@@ -167,6 +167,8 @@ ipa_deskprofile_get_filename_path(TALLOC_CTX *mem_ctx,
         goto done;
     }
 
+    perms = permuts[config_priority - 1];
+
     result = talloc_strdup(tmp_ctx, "");
     if (result == NULL) {
         ret = ENOMEM;
-- 
2.13.4
```
and also ...

```
From 8cc50e9b63d6610e7d5c52f57f8238a63f182f7e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fiden...@redhat.com>
Date: Thu, 17 Aug 2017 17:20:35 +0200
Subject: [PATCH] fixup! DESKPROFILE: Introduce the new IPA session provider

---
 src/providers/ipa/ipa_deskprofile_rules_util.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/providers/ipa/ipa_deskprofile_rules_util.c 
b/src/providers/ipa/ipa_deskprofile_rules_util.c
index 2ece5a1ee..1f5b7f9c5 100644
--- a/src/providers/ipa/ipa_deskprofile_rules_util.c
+++ b/src/providers/ipa/ipa_deskprofile_rules_util.c
@@ -26,6 +26,7 @@
 #include <ctype.h>
 #include <fcntl.h>
 
+#define DESKPROFILE_GLOBAL_POLICY_MIN_VALUE 1
 #define DESKPROFILE_GLOBAL_POLICY_MAX_VALUE 24
 
 enum deskprofile_name {
@@ -159,7 +160,8 @@ ipa_deskprofile_get_filename_path(TALLOC_CTX *mem_ctx,
         return ENOMEM;
     }
 
-    if (config_priority > DESKPROFILE_GLOBAL_POLICY_MAX_VALUE) {
+    if (config_priority < DESKPROFILE_GLOBAL_POLICY_MIN_VALUE ||
+        config_priority > DESKPROFILE_GLOBAL_POLICY_MAX_VALUE) {
         DEBUG(SSSDBG_CRIT_FAILURE,
               "The configuration priority has an invalid value: %d!\n",
               config_priority);
-- 
2.13.4
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/241#issuecomment-323102642

_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org