URL: https://github.com/SSSD/sssd/pull/374
Title: #374: IPA: Add threshold for sudo command and command group searches
pbrezina commented:
"""
I agree with Summit with both case. Case I also ask you to move the
thresholding logic
```c
+ if (ipa_sudo_cmds_exceed_threshold(state->conv, state->cmd_threshold)) {
+ DEBUG(SSSDBG_TRACE_FUNC,
+ "Command threshold [%d] exceeded, retrieving all sudo
commands\n",
+ state->cmd_threshold);
+ filter = talloc_asprintf(state, "(objectClass=%s)",
+ state->map_cmd->name);
+ } else {
+ filter = ipa_sudo_conv_cmd_filter(state, state->conv);
+ }
```
inside the conversion functions (`ipa_sudo_conv_cmd_filter`,
ipa_sudo_conv_cmdgoup_filter)?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/374#issuecomment-331395398
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
