URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework
fidencio commented: """ So, just by running pep8 in the python files I've seen: ``` [ffidenci@pessoa sssd]$ pep8 src/tests/multihost/basic/conftest.py src/tests/multihost/basic/test_basic.py src/tests/python/docs/conf.py src/tests/python/setup.py src/tests/python/sssd/__init__.py src/tests/python/sssd/testlib/__init__.py src/tests/python/sssd/testlib/common/__init__.py src/tests/python/sssd/testlib/common/authconfig.py src/tests/python/sssd/testlib/common/exceptions.py src/tests/python/sssd/testlib/common/libdirsrv.py src/tests/python/sssd/testlib/common/libkrb5.py src/tests/python/sssd/testlib/common/qe_class.py src/tests/python/sssd/testlib/common/utils.py src/tests/multihost/basic/conftest.py:28:1: E302 expected 2 blank lines, found 1 src/tests/multihost/basic/conftest.py:48:1: E302 expected 2 blank lines, found 1 src/tests/multihost/basic/conftest.py:59:1: E302 expected 2 blank lines, found 1 src/tests/multihost/basic/conftest.py:68:1: E302 expected 2 blank lines, found 1 src/tests/multihost/basic/conftest.py:79:1: E302 expected 2 blank lines, found 1 src/tests/multihost/basic/conftest.py:113:80: E501 line too long (89 > 79 characters) src/tests/multihost/basic/conftest.py:129:80: E501 line too long (82 > 79 characters) src/tests/multihost/basic/conftest.py:130:80: E501 line too long (82 > 79 characters) src/tests/multihost/basic/test_basic.py:29:80: E501 line too long (82 > 79 characters) src/tests/multihost/basic/test_basic.py:60:80: E501 line too long (87 > 79 characters) src/tests/multihost/basic/test_basic.py:66:80: E501 line too long (84 > 79 characters) src/tests/multihost/basic/test_basic.py:73:80: E501 line too long (87 > 79 characters) src/tests/multihost/basic/test_basic.py:83:80: E501 line too long (85 > 79 characters) src/tests/python/docs/conf.py:22:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:27:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:32:1: E302 expected 2 blank lines, found 1 src/tests/python/docs/conf.py:37:1: E302 expected 2 blank lines, found 1 src/tests/python/docs/conf.py:40:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:46:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:68:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:96:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:98:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:106:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:109:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:113:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:117:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:123:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:126:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:136:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:137:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:143:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:146:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:150:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:153:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:157:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:162:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:172:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:176:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:180:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:183:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:187:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:190:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:193:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:196:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:199:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:202:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:205:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:210:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:213:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:219:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:223:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:227:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:235:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:236:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:236:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:238:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:239:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:239:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:241:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:242:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:242:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:244:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:245:1: E122 continuation line missing indentation or outdented src/tests/python/docs/conf.py:245:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:258:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:262:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:265:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:268:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:271:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:274:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:281:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:284:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:287:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:302:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:305:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:308:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:311:1: E265 block comment should start with '# ' src/tests/python/docs/conf.py:314:1: W391 blank line at end of file src/tests/python/setup.py:18:13: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:18:15: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:19:16: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:19:18: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:20:20: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:20:22: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:21:25: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:21:27: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:22:15: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:22:17: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:23:12: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:23:14: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:24:17: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:24:19: E251 unexpected spaces around keyword / parameter equals src/tests/python/setup.py:29:25: E231 missing whitespace after ':' src/tests/python/sssd/testlib/common/authconfig.py:144:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/exceptions.py:28:80: E501 line too long (95 > 79 characters) src/tests/python/sssd/testlib/common/exceptions.py:34:80: E501 line too long (90 > 79 characters) src/tests/python/sssd/testlib/common/exceptions.py:40:80: E501 line too long (89 > 79 characters) src/tests/python/sssd/testlib/common/libdirsrv.py:185:1: E101 indentation contains mixed spaces and tabs src/tests/python/sssd/testlib/common/libdirsrv.py:185:1: W191 indentation contains tabs src/tests/python/sssd/testlib/common/libdirsrv.py:186:1: E101 indentation contains mixed spaces and tabs src/tests/python/sssd/testlib/common/libdirsrv.py:186:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/libdirsrv.py:189:5: E303 too many blank lines (2) src/tests/python/sssd/testlib/common/libdirsrv.py:368:80: E501 line too long (93 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:58:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:106:80: E501 line too long (95 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:118:80: E501 line too long (95 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:123:80: E501 line too long (96 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:129:80: E501 line too long (99 > 79 characters) src/tests/python/sssd/testlib/common/libkrb5.py:215:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/qe_class.py:178:80: E501 line too long (82 > 79 characters) src/tests/python/sssd/testlib/common/qe_class.py:209:80: E501 line too long (87 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:104:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:117:80: E501 line too long (85 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:260:80: E501 line too long (95 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:261:80: E501 line too long (101 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:262:1: E101 indentation contains mixed spaces and tabs src/tests/python/sssd/testlib/common/utils.py:262:1: W191 indentation contains tabs src/tests/python/sssd/testlib/common/utils.py:263:1: E101 indentation contains mixed spaces and tabs src/tests/python/sssd/testlib/common/utils.py:272:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:279:80: E501 line too long (86 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:307:80: E501 line too long (82 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:331:80: E501 line too long (88 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:350:80: E501 line too long (82 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:457:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:462:80: E501 line too long (85 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:643:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:662:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:664:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:680:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:697:80: E501 line too long (86 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:720:80: E501 line too long (80 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:736:80: E501 line too long (88 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:737:80: E501 line too long (87 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:738:80: E501 line too long (86 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:741:80: E501 line too long (86 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:742:80: E501 line too long (87 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:743:80: E501 line too long (104 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:764:80: E501 line too long (81 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:771:80: E501 line too long (93 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:782:80: E501 line too long (84 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:785:80: E501 line too long (83 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:811:80: E501 line too long (83 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:878:80: E501 line too long (86 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:896:80: E501 line too long (85 > 79 characters) src/tests/python/sssd/testlib/common/utils.py:909:80: E501 line too long (80 > 79 characters) ``` """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-343961498
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
