URL: https://github.com/SSSD/sssd/pull/702
Title: #702: NSS: Avoid changing the memory cache ownership away from the SSSD 
user

mzidek-rh commented:
"""
Could you add comment before this code (the comment can be "Make sure that the 
memory cache files are chowned to sssd.sssd even if the nss responder runs as 
root."):
```
    ret = fchown(mc_ctx->fd, mc_ctx->uid, mc_ctx->gid);
    if (ret != 0) {
        ret = errno;
        return ret;
    }
    ret = fchmod(mc_ctx->fd, S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH);
    if (ret == -1) {
        ret = errno;
        DEBUG(SSSDBG_CRIT_FAILURE, "Failed to chmod mmap file %s: %d(%s)\n",
                                   mc_ctx->file, ret, strerror(ret));
        return ret;
    }
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/702#issuecomment-444131943
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

Reply via email to