URL: https://github.com/SSSD/sssd/pull/736 Title: #736: KCM: Allow representing ccaches with a NULL principal
mzidek-rh commented: """ Given @simo alredy gave his LGTM, I will do a smoke test with the other KCM patches and this bug as well. If it goes well I will give a ack. But I have a comment. Now, this is not a NACK, I see you modified the cmocka tests to cover this issue, but I thing this is something that is also suitable to test in integration tests. There seem to be easy reproducer with the steps you provided. Do you think it makes sense to add test to src/tests/multihost/basic/test_kcm.py as well? Or is there a technical reason for this to not have integration test? """ See the full comment at https://github.com/SSSD/sssd/pull/736#issuecomment-458921014
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
