URL: https://github.com/SSSD/sssd/pull/776 Title: #776: NEGCACHE: repopulate negative cache after get_domains and initialize UPN negative cache as well
jhrozek commented: """ I have two more comments: 1. (minor) there is a comment ` /* All domains were local */` which I think is confusing. This part of code is executed when all non-local domains were processed, right? Do you think it would improve the readability of the code to fix the comment to say that there are no more non-local domains to try? 2. Given that `sss_dp_get_domains_process` is executed periodically, do you think the negative cache would grow with every execution? Or do you know if tdb is smart enough to only add one key-value pair? """ See the full comment at https://github.com/SSSD/sssd/pull/776#issuecomment-472405509
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
