URL: https://github.com/SSSD/sssd/pull/777
Title: #777: TESTS: Add a unit test for UPNs stored by sss_ncache_prepopulate
sumit-bose commented:
"""
Hi Jakub,
thanks for the tests. I wonder if you would like to add the following as well?
bye,
Sumit
```
diff --git a/src/tests/cmocka/test_negcache.c b/src/tests/cmocka/test_negcache.c
index f7a3b3f..9bddddd 100644
--- a/src/tests/cmocka/test_negcache.c
+++ b/src/tests/cmocka/test_negcache.c
@@ -618,7 +618,7 @@ static void test_sss_ncache_prepopulate(void **state)
struct sss_domain_info *subdomain;
struct sss_test_conf_param nss_params[] = {
- { "filter_users", "testuser_nss@UPN.REALM" },
+ { "filter_users", "testuser_nss@UPN.REALM, testuser_nss_short" },
{ NULL, NULL },
};
struct sss_test_conf_param dom_params[] = {
@@ -712,6 +712,27 @@ static void test_sss_ncache_prepopulate(void **state)
ret = sss_ncache_check_upn(ncache, tc->dom->subdomains,
"testuser_nss@UPN.REALM");
assert_int_equal(ret, EEXIST);
+
+ ret = sss_ncache_check_upn(ncache, tc->dom, "testuser_nss_short@"
TEST_DOM_NAME);
+ assert_int_equal(ret, EEXIST);
+
+ ret = sss_ncache_check_upn(ncache, tc->dom->subdomains,
"testuser_nss_short@" TEST_SUBDOM_NAME);
+ assert_int_equal(ret, EEXIST);
+
+ ret = check_user_in_ncache(ncache, tc->dom, "testuser_nss_short");
+ assert_int_equal(ret, EEXIST);
+
+ ret = check_user_in_ncache(ncache, tc->dom->subdomains,
"testuser_nss_short");
+ assert_int_equal(ret, EEXIST);
+
+ ret = sss_ncache_check_upn(ncache, tc->dom, "testuser1@" TEST_DOM_NAME);
+ assert_int_equal(ret, EEXIST);
+
+ ret = sss_ncache_check_upn(ncache, tc->dom, "testuser2@" TEST_DOM_NAME);
+ assert_int_equal(ret, EEXIST);
+
+ ret = sss_ncache_check_upn(ncache, tc->dom, "testuser3@somedomain");
+ assert_int_equal(ret, EEXIST);
}
static void test_sss_ncache_default_domain_suffix(void **state)
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/777#issuecomment-472814040
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
