URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache

sumit-bose commented:
"""
> Perhaps `ad_subdomains.c:193`? All other interactions with the list that I 
> foud is case insensitive.
> 
> ```c
>     is_ad_in_domains = false;
>     for (int i = 0; i < count; i++) {
>         is_ad_in_domains += strcmp(ad_domain, domains[i]) == 0 ? true : false;
>     }
> ```
> 
> I don't have a test environment handy, would you mind trying it out?

Yes, that did the trick, good catch. Can you include this into your patchset?

bye,
Sumit
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/820#issuecomment-519996331
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

Reply via email to