URL: https://github.com/SSSD/sssd/pull/905 Title: #905: WIP: Don't ignore host entries in Group Policy security filters
abbra commented: """ Few observations: - we already have code to translate between string/structure for SIDs, why there is a need for another one? - may be you can simplify the code by passing the structure you have instead of doing conversion? - please don't use explicit `gethostname()` to retrieve the name of the machine. Instead, use SSSD configuration as `ad_hostname` can be used to redefine your real hostname """ See the full comment at https://github.com/SSSD/sssd/pull/905#issuecomment-543558005
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
