URL: https://github.com/SSSD/sssd/pull/953 Author: elkoniu Title: #953: sysdb_sudo: Enable LDAP time format compatibility Action: opened
PR body: """ LDAP specification allows to ommit seconds and minutes in time border definition. In that case they defaults to zeros. Current sssd.sudo implementation requires precision up to seconds in time definition. This commit allows to lower the precision up to hours. Resolves: https://pagure.io/SSSD/sssd/issue/4118 """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/953/head:pr953 git checkout pr953
From f96d01cdcb46d1827dd2b4a80c232f5182ba604e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Po=C5=82awski?= <ppola...@redhat.com> Date: Tue, 3 Dec 2019 04:13:53 +0100 Subject: [PATCH] sysdb_sudo: Enable LDAP time format compatibility LDAP specification allows to ommit seconds and minutes in time border definition. In that case they defaults to zeros. Current sssd.sudo implementation requires precision up to seconds in time definition. This commit allows to lower the precision up to hours. Resolves: https://pagure.io/SSSD/sssd/issue/4118 --- src/db/sysdb_sudo.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/db/sysdb_sudo.c b/src/db/sysdb_sudo.c index 59d6824c0a..18088b017a 100644 --- a/src/db/sysdb_sudo.c +++ b/src/db/sysdb_sudo.c @@ -55,6 +55,22 @@ static errno_t sysdb_sudo_convert_time(const char *str, time_t *unix_time) "%Y%m%d%H%M%S.0%z", "%Y%m%d%H%M%S,0Z", "%Y%m%d%H%M%S,0%z", + /* LDAP specification says that minutes and seconds + might be omitted and in that case these are meant + to be treated as zeros [1]. + */ + "%Y%m%d%H%MZ", /* Discard seconds */ + "%Y%m%d%H%M%z", + "%Y%m%d%H%M.0Z", + "%Y%m%d%H%M.0%z", + "%Y%m%d%H%M,0Z", + "%Y%m%d%H%M,0%z", + "%Y%m%d%HZ", /* Discard minutes and seconds*/ + "%Y%m%d%H%z", + "%Y%m%d%H.0Z", + "%Y%m%d%H.0%z", + "%Y%m%d%H,0Z", + "%Y%m%d%H,0%z", NULL}; for (format = formats; *format != NULL; format++) {
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
