URL: https://github.com/SSSD/sssd/pull/5226
Title: #5226: python/pysss_nss_idmap: check return from functions

ikerexxe commented:
"""
> I think you just spotted yet another one place that needs fixing: 
> `TYPE_READY` calls `PyModule_AddObject()` and doesn't check a result.
> 
> Moreover, taking into account where this macro (`TYPE_READY`) is used, 
> `Py_XDECREF` should be called there as well, IMO.

Agreed. Take a look to the latest update, which contains all the aforementioned 
errors fixed.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5226#issuecomment-689423505
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

Reply via email to