URL: https://github.com/SSSD/sssd/pull/5300 Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented: """ Hi, thanks for the patches. My tests with various configurations with multiple existing, not-existing or not responding DCs went well. Coverity didn't had anything to complain either. While reading the patches I was wondering if it would make sense to create a macro for `"cldap"` since the string is used in a comparison? What do you think? This can be extended of course to the `"ldap"`, `"ldaps"` and `"ldapi"` strings when used to indicate an LDAP schema. Since this won't improve the readability I'm fine with keeping it as it is. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5300#issuecomment-698259812
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
