URL: https://github.com/SSSD/sssd/pull/5477
Title: #5477: DEBUG: Use () in program identifier instead of []

sigv commented:
"""
> I think the two lines from commit 1823353 also need to be changed.

`SYSLOG_IDENTIFIER=sssd[%s]` in src/util/sss_log.c has been replaced with 
`SYSLOG_IDENTIFIER=sssd(%s)`. As of now that is the last file in the diff if 
sorted alphabetically.

`SSSD_PRG_NAME=sssd[%s]` in src/util/debug.c may be retained with square 
brackets, as it does not relate to [syslog 
fields](https://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html#SYSLOG_FACILITY=).
 Would you prefer me to swap `SSSD_PRG_NAME` to be `sssd(%s)` as well in this 
PR?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5477#issuecomment-769651962
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

Reply via email to