URL: https://github.com/SSSD/sssd/pull/5474 Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented: """ > > Another thing: on "src/external/libcollection.m4" error message is "Please > > install libcollection-devel" but we do not require "-devel", merely > > binaries. > > Do we need it at all? AFAIK its pulled by libini but we don't use it directly > in SSSD, do we? This is complicated. libini_config contains .so that is linked with shared libs from all other ding-libs subpackages libini_config-devel explictly Requires libcollection-devel (and also libref_array-devel and libbasicobjects-devel) So right, everything is pulled automatically. And at this point I really question if we need 6 subpackages in ding-libs, but this is offtopic here. SSSD itself makes explicit use of ini_config and ref_array. I didn't find any usage of collection API. So probably yes, we could remove check for colelction entirely and delegate this to ini_config deps. But what I mean is a more simple note: debug message doesn't correspond actual check. """ See the full comment at https://github.com/SSSD/sssd/pull/5474#issuecomment-772455403
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
